Problems importing invalid URLs from Firefox

Vergeh

[b]Version Information:[/b]

OS: Windows XP 64-bit Professional

Firefox Version: 13.0

Plugin Version: 3.9.4.b1 (Reproduced with 3.9.4)

App version: 1.0.9.294 (Trial Mode)



[b]Steps to Reproduce:[/b][list=1]

[*]Opened Firefox, opened 1password tool, logged in without problems.

[*]Went to Settings > Import Saved Firefox Passwords

[*]Tool window closes. No error dialog is shown, program continues running. Logins are not imported, even after restarting the app.

[/list]

[b]Workarounds attempted[/b][list]

[*]Uninstalled plugin, closed firefox, deleted OnePassword.sqlite, reinstalled.

[*]Did the above, but upgraded to beta version.

[*]Attempted export/import using Password-Exporter ([url="https://github.com/fligtar/password-exporter/wiki/"]https://github.com/fligtar/password-exporter/wiki/[/url]). Import failed with no feedback.

[/list]

khad

To help us track down the issue more quickly, could you please email us your Diagnostics Report? Select **Help > Diagnostics Report > Export to File** from the menu bar in 1Password. Then attach the report to an email to support AT agilebits.com. Please include a link to this forum thread so we can "connect the dots" when we see your Diagnostics Report in our inbox.



Once we see your report we should be able to help more. Thanks in advance!

Vergeh

Sent with a link. Thanks for your quick response!

MikeT

Hi Vergeh,



I think the problem is with the source, there may be some entries in the Firefox database that prevents 1Password from parsing it properly.



Can you open the CSV file that you created with the Password Exporter and tell me if you see any weird entries or any items with non-standard URLs like chrome:// or anything that doesn't look like http://?



Please let me know.

Vergeh

There were three passwords in my 117-password list that were used by third-party addons. The commonality these three entries shared was that the formSubmitURL field in these cases, and only these three cases, were not valid URLs. My guess is that your importer performs some sort of regex on this field, and the invalid URLs were causing it to abend somehow. Naturally I don't expect you to support 100% of third-party addons, but I hope you're able to patch the plugin so the importer doesn't crash, and these passwords are at the very least rejected with some sort of user feedback.



Thanks for pointing me in the right direction, I was able to get the rest of my passwords imported just fine!



Edit: In the interest of context, here are the three entries, with passwords, IPs and usernames redacted, of course.



[CODE]

<entry host="http://longfocus.gmanager.account" user="REDACTED" password="REDACTED" formSubmitURL="/" httpRealm="" userFieldName="" passFieldName=""/>

<entry host="http://longfocus.gmanager.account" user="REDACTED" password="REDACTED" formSubmitURL="/" httpRealm="" userFieldName="" passFieldName=""/>

<entry host="http://ftp.192.168.1.xxx" user="REDACTED" password="REDACTED" formSubmitURL="FireFTP" httpRealm="" userFieldName="" passFieldName=""/>

[/CODE]



These belong to the now-defunct Gmail Manager plugin, and the popular FireFTP plugin respectively.

khad

Thanks so much for following up on this, Vergeh. I will pass this data along to the developers so hopefully we can improve this in a future update!



Much appreciated.

funkyhorst

Hi guys,

I just bought the Mac/Windows bundle so I can finally sync the passwords I use at work with the ones I use at home on my mac. I installed 1password 3.9.4 on the pc at work, running Windows 7 V. 6.1. I'm browsing with Firefox 12.0. Unfortunately, the "import saved firefox plugins" button doesn't do anything. No error message, it just doesn't import.



Any hints?



Thanks a lot.



Tim





Troubleshooting report:



[b] 1Password Troubleshooting Report[/b]



When experiencing problems this page can help you diagnose the cause. Common configuration issues detected on your system will be highlighted below, along with troubleshooting tips to resolve them.

If the support team requests this report, you send it to them by saving this page (select File > Save As) and then attaching the saved file to your email response.

[b] System Information[/b]

System time 2012-6-15 : 16:19:35 Browser version Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20100101 Firefox/12.0

[b] 1Password Extension Information[/b]

Extension version 3.9.4 ([url="http://cdn.agilebits.com/dist/1P/ext/release_notes.html"]release notes[/url]) Database created at 2012-6-15 : 12:48:40 Uptime (mins) 147

[b] 1Password Helper Information[/b]

Connection status Connected Last Sync Error 1Password Helper version 1.0.9 (295) Heart beat interval (sec) 20 Heart beat acknowledged No Number of heart beats 0 Round trip elapse time (ms) Data update in progress No Last data update completed at 2012-6-15 : 16:13:54 Data update elapse time (ms) 80

[b] 1Password Extension Settings[/b]

Autosave enabled YES Autosubmit enabled YES Universal Unlock enabled YES Conceal Passwords YES Avoid Autosave on Domains ""

khad

Welcome to the forums, funkyhorst! Sorry to hear you are having some trouble. It sounds like the issue is probably related to "invalid" URLs in your Firefox password data, so I have merged your post with this existing thread. Can you check to see if that is the case? They usually come from other extensions saving information in Firefox's password manager that are only meant for the other extension (not websites) as in [url="http://forum.agilebits.com/index.php?/topic/10501-problems-importing-invalid-urls-from-firefox/page__view__findpost__p__60271"]post #6 above[/url].



Please let me know what you uncover in: [b]Options > Options > Security > Saved Passwords[/b]

funkyhorst

Hello! I tried the mentioned export/import using Password-Exporter, and it worked for me. I didn't have invalid passwords in my Firefox Keychain and have never used other password applications.

Thanks!

khad

I'm glad you were able to get your data imported. I've not seen any problem importing in Firefox that was not related to invalid URLs. Your use of another "password application" should have no bearing on 1Password importing passwords from Firefox.



Without more details it may be impossible for us to track down what happened on your machine, but if you are willing to share a list of the URLs it could help us narrow down the issue. You can send them to [font=courier new,courier,monospace][b]support @ agilebits.com[/b][/font] if you are so inclined.



Cheers,